diff options
| author | Xi Wang <[email protected]> | 2011-12-27 09:43:19 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2011-12-28 19:08:08 +0000 |
| commit | ba1cffe0257bcd4d0070bc0e64f8ead97fefd148 (patch) | |
| tree | 5584b7816f7eb46953611ec35628c6924ea5a2af /net/unix/sysctl_net_unix.c | |
| parent | genetlink: add auto module loading (diff) | |
| download | kernel-ba1cffe0257bcd4d0070bc0e64f8ead97fefd148.tar.gz kernel-ba1cffe0257bcd4d0070bc0e64f8ead97fefd148.zip | |
ax25: avoid overflows in ax25_setsockopt()
Commit be639ac6 ("NET: AX.25: Check ioctl arguments to avoid overflows
further down the road") rejects very large arguments, but doesn't
completely fix overflows on 64-bit systems. Consider the AX25_T2 case.
int opt;
...
if (opt < 1 || opt > ULONG_MAX / HZ) {
res = -EINVAL;
break;
}
ax25->t2 = opt * HZ;
The 32-bit multiplication opt * HZ would overflow before being assigned
to 64-bit ax25->t2. This patch changes "opt" to unsigned long.
Signed-off-by: Xi Wang <[email protected]>
Cc: Ralf Baechle <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions