diff options
| author | Jens Axboe <[email protected]> | 2025-01-15 16:05:15 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2025-01-24 08:37:30 +0000 |
| commit | 5e0e02f0d7e52cfc8b1adfc778dd02181d8b47b4 (patch) | |
| tree | 585b1b169efa2c2a2d229f309a75d02e064d20c7 /net/unix/sysctl_net_unix.c | |
| parent | Merge tag 'sched_ext-for-6.14' of git://git.kernel.org/pub/scm/linux/kernel/g... (diff) | |
| download | kernel-5e0e02f0d7e52cfc8b1adfc778dd02181d8b47b4.tar.gz kernel-5e0e02f0d7e52cfc8b1adfc778dd02181d8b47b4.zip | |
futex: Pass in task to futex_queue()
futex_queue() -> __futex_queue() uses 'current' as the task to store in
the struct futex_q->task field. This is fine for synchronous usage of
the futex infrastructure, but it's not always correct when used by
io_uring where the task doing the initial futex_queue() might not be
available later on. This doesn't lead to any issues currently, as the
io_uring side doesn't support PI futexes, but it does leave a
potentially dangling pointer which is never a good idea.
Have futex_queue() take a task_struct argument, and have the regular
callers pass in 'current' for that. Meanwhile io_uring can just pass in
NULL, as the task should never be used off that path. In theory
req->tctx->task could be used here, but there's no point populating it
with a task field that will never be used anyway.
Reported-by: Jann Horn <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/all/[email protected]
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions
