diff options
| author | Allison Henderson <[email protected]> | 2024-02-09 02:28:54 +0000 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2024-02-13 09:25:30 +0000 |
| commit | f1acf1ac84d2ae97b7889b87223c1064df850069 (patch) | |
| tree | 494b780f4ed692eccf50eb7e9a136bb3e31f02a6 /net/unix/garbage.c | |
| parent | net: add rcu safety to rtnl_prop_list_size() (diff) | |
| download | kernel-f1acf1ac84d2ae97b7889b87223c1064df850069.tar.gz kernel-f1acf1ac84d2ae97b7889b87223c1064df850069.zip | |
net:rds: Fix possible deadlock in rds_message_put
Functions rds_still_queued and rds_clear_recv_queue lock a given socket
in order to safely iterate over the incoming rds messages. However
calling rds_inc_put while under this lock creates a potential deadlock.
rds_inc_put may eventually call rds_message_purge, which will lock
m_rs_lock. This is the incorrect locking order since m_rs_lock is
meant to be locked before the socket. To fix this, we move the message
item to a local list or variable that wont need rs_recv_lock protection.
Then we can safely call rds_inc_put on any item stored locally after
rs_recv_lock is released.
Fixes: bdbe6fbc6a2f ("RDS: recv.c")
Reported-by: [email protected]
Reported-by: [email protected]
Signed-off-by: Allison Henderson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Diffstat (limited to 'net/unix/garbage.c')
0 files changed, 0 insertions, 0 deletions
