diff options
| author | Gerrit Renker <[email protected]> | 2007-11-25 00:09:35 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2008-01-28 22:54:59 +0000 |
| commit | 83399361c30f2ffae20ee348ba9ada9a856d499a (patch) | |
| tree | 51f5399c9d394ab4ec1483d7bb908566a19e8792 /net/unix/af_unix.c | |
| parent | [CCID2]: Redundant debugging output (diff) | |
| download | kernel-83399361c30f2ffae20ee348ba9ada9a856d499a.tar.gz kernel-83399361c30f2ffae20ee348ba9ada9a856d499a.zip | |
[CCID2]: Remove redundant synchronisation variable
This removes the synchronisation variable `ccid2hctx_sendwait', which is set to 1
when the CCID2 sender may send a new packet, and which is set to 0 otherwise
The variable is redundant, since it is only used in combination with the hc_tx_send_packet/
hc_tx_packet_sent function pair. Both functions are called under socket lock, so the
following happens when the CCID2 may send a new packet:
* it sets sendwait = 1 in tx_send_packet and returns 0;
* the subsequent call to tx_packet_sent clears the sendwait flag;
* since tx_send_packet returns 0 if and only if sendwait == 1, the BUG_ON condition
in tx_packet_sent is never satisfied, since that function is never called when
tx_send_packet returns a value different from 0 (cf. dccp_write_xmit);
* the call to tx_packet_sent clears the flag so that the condition "!sendwait" is
true the next time tx_packet_sent is called.
In other words, it is sufficient to just return 0 / not-0 to synchronise tx_send_packet
and tx_packet_sent -- which is what the patch does.
Signed-off-by: Gerrit Renker <[email protected]>
Acked-by: Ian McDonald <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions
