diff options
| author | Steven Rostedt (VMware) <[email protected]> | 2021-06-08 01:39:08 +0000 |
|---|---|---|
| committer | Steven Rostedt (VMware) <[email protected]> | 2021-06-08 20:44:00 +0000 |
| commit | 6c14133d2d3f768e0a35128faac8aa6ed4815051 (patch) | |
| tree | 0e167a71dda06575dfe90278df847fd8430de508 /net/unix/af_unix.c | |
| parent | tools/bootconfig: Fix a build error accroding to undefined fallthrough (diff) | |
| download | kernel-6c14133d2d3f768e0a35128faac8aa6ed4815051.tar.gz kernel-6c14133d2d3f768e0a35128faac8aa6ed4815051.zip | |
ftrace: Do not blindly read the ip address in ftrace_bug()
It was reported that a bug on arm64 caused a bad ip address to be used for
updating into a nop in ftrace_init(), but the error path (rightfully)
returned -EINVAL and not -EFAULT, as the bug caused more than one error to
occur. But because -EINVAL was returned, the ftrace_bug() tried to report
what was at the location of the ip address, and read it directly. This
caused the machine to panic, as the ip was not pointing to a valid memory
address.
Instead, read the ip address with copy_from_kernel_nofault() to safely
access the memory, and if it faults, report that the address faulted,
otherwise report what was in that location.
Link: https://lore.kernel.org/lkml/[email protected]/
Cc: [email protected]
Fixes: 05736a427f7e1 ("ftrace: warn on failure to disable mcount callers")
Reported-by: Mark-PK Tsai <[email protected]>
Tested-by: Mark-PK Tsai <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions
