aboutsummaryrefslogtreecommitdiffstats
path: root/net/unix/af_unix.c
diff options
context:
space:
mode:
authorKarsten Graul <[email protected]>2021-11-24 12:32:37 +0000
committerJakub Kicinski <[email protected]>2021-11-25 03:02:21 +0000
commit587acad41f1bc48e16f42bb2aca63bf323380be8 (patch)
treef2cdb384949c5d332d0a57aa0b0bdb7c48ffd48f /net/unix/af_unix.c
parentMerge branch 'phylink-resolve-fixes' (diff)
downloadkernel-587acad41f1bc48e16f42bb2aca63bf323380be8.tar.gz
kernel-587acad41f1bc48e16f42bb2aca63bf323380be8.zip
net/smc: Fix NULL pointer dereferencing in smc_vlan_by_tcpsk()
Coverity reports a possible NULL dereferencing problem: in smc_vlan_by_tcpsk(): 6. returned_null: netdev_lower_get_next returns NULL (checked 29 out of 30 times). 7. var_assigned: Assigning: ndev = NULL return value from netdev_lower_get_next. 1623 ndev = (struct net_device *)netdev_lower_get_next(ndev, &lower); CID 1468509 (#1 of 1): Dereference null return value (NULL_RETURNS) 8. dereference: Dereferencing a pointer that might be NULL ndev when calling is_vlan_dev. 1624 if (is_vlan_dev(ndev)) { Remove the manual implementation and use netdev_walk_all_lower_dev() to iterate over the lower devices. While on it remove an obsolete function parameter comment. Fixes: cb9d43f67754 ("net/smc: determine vlan_id of stacked net_device") Suggested-by: Julian Wiedmann <[email protected]> Signed-off-by: Karsten Graul <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions