diff options
| author | Shannon Nelson <[email protected]> | 2025-04-21 17:46:06 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-04-24 01:50:17 +0000 |
| commit | 3f77c3dfffc7063428b100c4945ca2a7a8680380 (patch) | |
| tree | 09ecbbac33d94497146f8a3265ddfd00c9557637 /net/unix/af_unix.c | |
| parent | pds_core: Remove unnecessary check in pds_client_adminq_cmd() (diff) | |
| download | kernel-3f77c3dfffc7063428b100c4945ca2a7a8680380.tar.gz kernel-3f77c3dfffc7063428b100c4945ca2a7a8680380.zip | |
pds_core: make wait_context part of q_info
Make the wait_context a full part of the q_info struct rather
than a stack variable that goes away after pdsc_adminq_post()
is done so that the context is still available after the wait
loop has given up.
There was a case where a slow development firmware caused
the adminq request to time out, but then later the FW finally
finished the request and sent the interrupt. The handler tried
to complete_all() the completion context that had been created
on the stack in pdsc_adminq_post() but no longer existed.
This caused bad pointer usage, kernel crashes, and much wailing
and gnashing of teeth.
Fixes: 01ba61b55b20 ("pds_core: Add adminq processing and commands")
Reviewed-by: Simon Horman <[email protected]>
Signed-off-by: Shannon Nelson <[email protected]>
Reviewed-by: Jacob Keller <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions