diff options
| author | Toke Høiland-Jørgensen <[email protected]> | 2021-06-24 16:06:09 +0000 |
|---|---|---|
| committer | Daniel Borkmann <[email protected]> | 2021-06-24 17:46:39 +0000 |
| commit | 0cc84b9a6003fa7f6ef5d19e7c8532a01cd41776 (patch) | |
| tree | 64460f00c0ded7b3f5141814faedc5c14ba7f63f /net/unix/af_unix.c | |
| parent | stmmac: Remove rcu_read_lock() around XDP program invocation (diff) | |
| download | kernel-0cc84b9a6003fa7f6ef5d19e7c8532a01cd41776.tar.gz kernel-0cc84b9a6003fa7f6ef5d19e7c8532a01cd41776.zip | |
ti: Remove rcu_read_lock() around XDP program invocation
The cpsw driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP
program invocations. However, the actual lifetime of the objects referred
by the XDP program invocation is longer, all the way through to the call to
xdp_do_flush(), making the scope of the rcu_read_lock() too small. This
turns out to be harmless because it all happens in a single NAPI poll
cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock()
misleading.
Rather than extend the scope of the rcu_read_lock(), just get rid of it
entirely. With the addition of RCU annotations to the XDP_REDIRECT map
types that take bh execution into account, lockdep even understands this to
be safe, so there's really no reason to keep it around.
Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Tested-by: Grygorii Strashko <[email protected]>
Reviewed-by: Grygorii Strashko <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions
