diff options
| author | Eric Dumazet <[email protected]> | 2018-03-31 19:58:58 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2018-04-01 03:25:40 +0000 |
| commit | bf66337140c64c27fa37222b7abca7e49d63fb57 (patch) | |
| tree | 21a458948982fa21406bf356534516789d435661 /net/tls/tls_main.c | |
| parent | inet: frags: reorganize struct netns_frags (diff) | |
| download | kernel-bf66337140c64c27fa37222b7abca7e49d63fb57.tar.gz kernel-bf66337140c64c27fa37222b7abca7e49d63fb57.zip | |
inet: frags: get rid of ipfrag_skb_cb/FRAG_CB
ip_defrag uses skb->cb[] to store the fragment offset, and unfortunately
this integer is currently in a different cache line than skb->next,
meaning that we use two cache lines per skb when finding the insertion point.
By aliasing skb->ip_defrag_offset and skb->dev, we pack all the fields
in a single cache line and save precious memory bandwidth.
Note that after the fast path added by Changli Gao in commit
d6bebca92c66 ("fragment: add fast path for in-order fragments")
this change wont help the fast path, since we still need
to access prev->len (2nd cache line), but will show great
benefits when slow path is entered, since we perform
a linear scan of a potentially long list.
Also, note that this potential long list is an attack vector,
we might consider also using an rb-tree there eventually.
Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/tls/tls_main.c')
0 files changed, 0 insertions, 0 deletions
