diff options
| author | Elena Reshetova <[email protected]> | 2017-10-20 07:23:47 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2017-10-22 01:22:39 +0000 |
| commit | d780cd44e3cea119a3346e6d7c04d35b9c50d54b (patch) | |
| tree | 48c55971fdae4843e39d2d123ce00ef3f18f13ec /net/tipc | |
| parent | drivers, net, ppp: convert asyncppp.refcnt from atomic_t to refcount_t (diff) | |
| download | kernel-d780cd44e3cea119a3346e6d7c04d35b9c50d54b.tar.gz kernel-d780cd44e3cea119a3346e6d7c04d35b9c50d54b.zip | |
drivers, net, ppp: convert ppp_file.refcnt from atomic_t to refcount_t
atomic_t variables are currently used to implement reference
counters with the following properties:
- counter is initialized to 1 using atomic_set()
- a resource is freed upon counter reaching zero
- once counter reaches zero, its further
increments aren't allowed
- counter schema uses basic atomic operations
(set, inc, inc_not_zero, dec_and_test, etc.)
Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.
The variable ppp_file.refcnt is used as pure reference counter.
Convert it to refcount_t and fix up the operations.
Suggested-by: Kees Cook <[email protected]>
Reviewed-by: David Windsor <[email protected]>
Reviewed-by: Hans Liljestrand <[email protected]>
Signed-off-by: Elena Reshetova <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/tipc')
0 files changed, 0 insertions, 0 deletions
