diff options
| author | Erik Hugne <[email protected]> | 2014-08-15 14:44:35 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2014-08-17 03:17:34 +0000 |
| commit | ac32c7f705692b92fe12dcbe88fe87136fdfff6f (patch) | |
| tree | 9338c8e950a138f41d5bc1c2fa9f5a669e88050f /net/tipc/socket.c | |
| parent | net: phy: smsc: move smsc_phy_config_init reset part in a soft_reset function (diff) | |
| download | kernel-ac32c7f705692b92fe12dcbe88fe87136fdfff6f.tar.gz kernel-ac32c7f705692b92fe12dcbe88fe87136fdfff6f.zip | |
tipc: fix message importance range check
Commit 3b4f302d8578 ("tipc: eliminate
redundant locking") introduced a bug by removing the sanity check
for message importance, allowing programs to assign any value to
the msg_user field. This will mess up the packet reception logic
and may cause random link resets.
Signed-off-by: Erik Hugne <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/tipc/socket.c')
| -rw-r--r-- | net/tipc/socket.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 7d423ee10897..ff8c8118d56e 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -1973,7 +1973,7 @@ static int tipc_setsockopt(struct socket *sock, int lvl, int opt, switch (opt) { case TIPC_IMPORTANCE: - tipc_port_set_importance(port, value); + res = tipc_port_set_importance(port, value); break; case TIPC_SRC_DROPPABLE: if (sock->type != SOCK_STREAM) |