diff options
| author | Eric Dumazet <[email protected]> | 2019-04-16 17:55:20 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2019-04-17 04:47:39 +0000 |
| commit | 50ce163a72d817a99e8974222dcf2886d5deb1ae (patch) | |
| tree | d23ffa9fbfcba49b44e070227d300534ab97f3ab /net/tipc/socket.c | |
| parent | ocelot: Clean up stats update deferred work (diff) | |
| download | kernel-50ce163a72d817a99e8974222dcf2886d5deb1ae.tar.gz kernel-50ce163a72d817a99e8974222dcf2886d5deb1ae.zip | |
tcp: tcp_grow_window() needs to respect tcp_space()
For some reason, tcp_grow_window() correctly tests if enough room
is present before attempting to increase tp->rcv_ssthresh,
but does not prevent it to grow past tcp_space()
This is causing hard to debug issues, like failing
the (__tcp_select_window(sk) >= tp->rcv_wnd) test
in __tcp_ack_snd_check(), causing ACK delays and possibly
slow flows.
Depending on tcp_rmem[2], MTU, skb->len/skb->truesize ratio,
we can see the problem happening on "netperf -t TCP_RR -- -r 2000,2000"
after about 60 round trips, when the active side no longer sends
immediate acks.
This bug predates git history.
Signed-off-by: Eric Dumazet <[email protected]>
Acked-by: Soheil Hassas Yeganeh <[email protected]>
Acked-by: Neal Cardwell <[email protected]>
Acked-by: Wei Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/tipc/socket.c')
0 files changed, 0 insertions, 0 deletions