diff options
| author | Oleg Nesterov <[email protected]> | 2011-07-08 17:13:54 +0000 |
|---|---|---|
| committer | Oleg Nesterov <[email protected]> | 2011-07-17 18:23:51 +0000 |
| commit | dcace06cc29df927a74a6bc0e57b9bef87704377 (patch) | |
| tree | 9a04518032869b1ed79933026379ea0d7081e43a /net/tipc/node.c | |
| parent | ptrace_init_task: initialize child->jobctl explicitly (diff) | |
| download | kernel-dcace06cc29df927a74a6bc0e57b9bef87704377.tar.gz kernel-dcace06cc29df927a74a6bc0e57b9bef87704377.zip | |
ptrace: mv send-SIGSTOP from do_fork() to ptrace_init_task()
If the new child is traced, do_fork() adds the pending SIGSTOP.
It assumes that either it is traced because of auto-attach or the
tracer attached later, in both cases sigaddset/set_thread_flag is
correct even if SIGSTOP is already pending.
Now that we have PTRACE_SEIZE this is no longer right in the latter
case. If the tracer does PTRACE_SEIZE after copy_process() makes the
child visible the queued SIGSTOP is wrong.
We could check PT_SEIZED bit and change ptrace_attach() to set both
PT_PTRACED and PT_SEIZED bits simultaneously but see the next patch,
we need to know whether this child was auto-attached or not anyway.
So this patch simply moves this code to ptrace_init_task(), this
way we can never race with ptrace_attach().
Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Tejun Heo <[email protected]>
Diffstat (limited to 'net/tipc/node.c')
0 files changed, 0 insertions, 0 deletions
