diff options
| author | Zhangfei Gao <[email protected]> | 2025-03-17 01:13:52 +0000 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2025-04-11 17:53:21 +0000 |
| commit | c8ba3f8aff672a5ea36e895f0f8f657271d855d7 (patch) | |
| tree | 9f3027fd8039671573db940ade1d8172e09bb6f7 /net/tipc/node.c | |
| parent | Linux 6.15-rc1 (diff) | |
| download | kernel-c8ba3f8aff672a5ea36e895f0f8f657271d855d7.tar.gz kernel-c8ba3f8aff672a5ea36e895f0f8f657271d855d7.zip | |
PCI: Run quirk_huawei_pcie_sva() before arm_smmu_probe_device()
quirk_huawei_pcie_sva() sets properties needed by arm_smmu_probe_device(),
but bcb81ac6ae3c ("iommu: Get DT/ACPI parsing into the proper probe path")
changed the iommu_probe_device() flow so arm_smmu_probe_device() is now
invoked before the quirk, leading to failures like this:
reg-dummy reg-dummy: late IOMMU probe at driver bind, something fishy here!
WARNING: CPU: 0 PID: 1 at drivers/iommu/iommu.c:449 __iommu_probe_device+0x140/0x570
RIP: 0010:__iommu_probe_device+0x140/0x570
The SR-IOV enumeration ordering changes like this:
pci_iov_add_virtfn
pci_device_add
pci_fixup_device(pci_fixup_header) <--
device_add
bus_notify
iommu_bus_notifier
+ iommu_probe_device
+ arm_smmu_probe_device
pci_bus_add_device
pci_fixup_device(pci_fixup_final) <--
device_attach
driver_probe_device
really_probe
pci_dma_configure
acpi_dma_configure_id
- iommu_probe_device
- arm_smmu_probe_device
The non-SR-IOV case is similar in that pci_device_add() is called from
pci_scan_single_device() in the generic enumeration path and
pci_bus_add_device() is called later, after all host bridges have been
enumerated.
Declare quirk_huawei_pcie_sva() as a header fixup to ensure that it happens
before arm_smmu_probe_device().
Fixes: bcb81ac6ae3c ("iommu: Get DT/ACPI parsing into the proper probe path")
Reported-by: Chaitanya Kumar Borah <[email protected]>
Closes: https://lore.kernel.org/all/SJ1PR11MB61295DE21A1184AEE0786E25B9D22@SJ1PR11MB6129.namprd11.prod.outlook.com/
Signed-off-by: Zhangfei Gao <[email protected]>
[bhelgaas: commit log, add failure info and reporter]
Signed-off-by: Bjorn Helgaas <[email protected]>
Link: https://patch.msgid.link/[email protected]
Diffstat (limited to 'net/tipc/node.c')
0 files changed, 0 insertions, 0 deletions
