diff options
| author | Geert Uytterhoeven <[email protected]> | 2017-12-07 10:15:19 +0000 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2017-12-12 17:01:47 +0000 |
| commit | 0c31f1d7be1b5c4858b1d714dcefa25f41428cab (patch) | |
| tree | e39aee603c3c12ad4600cec69431e0e4ab5f7746 /net/tipc/node.c | |
| parent | x86/PCI: Only enable a 64bit BAR on single-socket AMD Family 15h (diff) | |
| download | kernel-0c31f1d7be1b5c4858b1d714dcefa25f41428cab.tar.gz kernel-0c31f1d7be1b5c4858b1d714dcefa25f41428cab.zip | |
PCI: rcar: Fix use-after-free in probe error path
If CONFIG_DEBUG_SLAB=y, and no PCIe card is inserted, the kernel crashes
during probe on r8a7791/koelsch:
rcar-pcie fe000000.pcie: PCIe link down
Unable to handle kernel paging request at virtual address 6b6b6b6b
(seeing this message requires earlycon and keep_bootcon).
Indeed, pci_free_host_bridge() frees the PCI host bridge, including the
embedded rcar_pcie object, so pci_free_resource_list() must not be called
afterwards.
To fix this, move the call to pci_free_resource_list() up, and update the
label name accordingly.
Fixes: ddd535f1ea3eb27e ("PCI: rcar: Fix memory leak when no PCIe card is inserted")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Acked-by: Simon Horman <[email protected]>
Acked-by: Lorenzo Pieralisi <[email protected]>
Diffstat (limited to 'net/tipc/node.c')
0 files changed, 0 insertions, 0 deletions