diff options
| author | Petri Gynther <[email protected]> | 2015-03-12 22:48:00 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2015-03-13 19:48:15 +0000 |
| commit | d6707bec598649450ee0887bf11896e525777874 (patch) | |
| tree | 8e33b10d376a8365d6d369ffd52ae8a461737719 /net/switchdev/switchdev.c | |
| parent | Merge branch 'tcp_metrics_netns_debloat' (diff) | |
| download | kernel-d6707bec598649450ee0887bf11896e525777874.tar.gz kernel-d6707bec598649450ee0887bf11896e525777874.zip | |
net: bcmgenet: rewrite bcmgenet_rx_refill()
Currently, bcmgenet_desc_rx() calls bcmgenet_rx_refill() at the end of
Rx packet processing loop, after the current Rx packet has already been
passed to napi_gro_receive(). However, bcmgenet_rx_refill() might fail
to allocate a new Rx skb, thus leaving a hole on the Rx queue where no
valid Rx buffer exists.
To eliminate this situation:
1. Rewrite bcmgenet_rx_refill() to retain the current Rx skb on the Rx
queue if a new replacement Rx skb can't be allocated and DMA-mapped.
In this case, the data on the current Rx skb is effectively dropped.
2. Modify bcmgenet_desc_rx() to call bcmgenet_rx_refill() at the top of
Rx packet processing loop, so that the new replacement Rx skb is
already in place before the current Rx skb is processed.
Signed-off-by: Petri Gynther <[email protected]>
Tested-by: Jaedon Shin <[email protected]>--
Reviewed-by: Florian Fainelli <[email protected]>
Tested-by: Florian Fainelli <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/switchdev/switchdev.c')
0 files changed, 0 insertions, 0 deletions
