aboutsummaryrefslogtreecommitdiffstats
path: root/net/switchdev/switchdev.c
diff options
context:
space:
mode:
authorNicholas Bellinger <[email protected]>2016-10-16 07:27:42 +0000
committerNicholas Bellinger <[email protected]>2016-10-20 04:22:34 +0000
commit61f36166c245e563c7a2b624f4c78c5ce0f680d6 (patch)
tree338291f4751dc0ed4a39c30c5e3a38c448741d7b /net/switchdev/switchdev.c
parenttarget: Don't override EXTENDED_COPY xcopy_pt_cmd SCSI status code (diff)
downloadkernel-61f36166c245e563c7a2b624f4c78c5ce0f680d6.tar.gz
kernel-61f36166c245e563c7a2b624f4c78c5ce0f680d6.zip
Revert "target: Fix residual overflow handling in target_complete_cmd_with_length"
This reverts commit c1ccbfe0311e2380a6d2dcb0714b36904f5d586f. Reverting this patch, as it incorrectly assumes the additional length for INQUIRY in target_complete_cmd_with_length() is SCSI allocation length, which breaks existing user-space code when SCSI allocation length is smaller than additional length. root@scsi-mq:~# sg_inq --len=4 -vvvv /dev/sdb found bsg_major=253 open /dev/sdb with flags=0x800 inquiry cdb: 12 00 00 00 04 00 duration=0 ms inquiry: pass-through requested 4 bytes (data-in) but got -28 bytes inquiry: pass-through can't get negative bytes, say it got none inquiry: got too few bytes (0) INQUIRY resid (32) should never exceed requested len=4 inquiry: failed requesting 4 byte response: Malformed response to SCSI command [resid=32] AFAICT the original change was not to address a specific host issue, so go ahead and revert to original logic for now. Cc: Douglas Gilbert <[email protected]> Cc: Martin K. Petersen <[email protected]> Cc: Sumit Rai <[email protected]> Cc: [email protected] # 4.8+ Signed-off-by: Nicholas Bellinger <[email protected]>
Diffstat (limited to 'net/switchdev/switchdev.c')
0 files changed, 0 insertions, 0 deletions