diff options
| author | Arnd Bergmann <[email protected]> | 2016-03-14 14:29:45 +0000 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2016-03-18 19:22:55 +0000 |
| commit | 3deb9438d34a09f6796639b652a01d110aca9f75 (patch) | |
| tree | 1b22dbfd712b679aa6f23c0c51af55f37af09128 /net/switchdev/switchdev.c | |
| parent | lpfc: fix misleading indentation (diff) | |
| download | kernel-3deb9438d34a09f6796639b652a01d110aca9f75.tar.gz kernel-3deb9438d34a09f6796639b652a01d110aca9f75.zip | |
megaraid_sas: add missing curly braces in ioctl handler
gcc-6 found a dubious indentation in the megasas_mgmt_fw_ioctl
function:
drivers/scsi/megaraid/megaraid_sas_base.c: In function 'megasas_mgmt_fw_ioctl':
drivers/scsi/megaraid/megaraid_sas_base.c:6658:4: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
kbuff_arr[i] = NULL;
^~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_base.c:6653:3: note: ...this 'if' clause, but it is not
if (kbuff_arr[i])
^~
The code is actually correct, as there is no downside in clearing a NULL
pointer again.
This clarifies the code and avoids the warning by adding extra curly
braces.
Signed-off-by: Arnd Bergmann <[email protected]>
Fixes: 90dc9d98f01b ("megaraid_sas : MFI MPT linked list corruption fix")
Reviewed-by: Hannes Reinecke <[email protected]>
Acked-by: Sumit Saxena <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'net/switchdev/switchdev.c')
0 files changed, 0 insertions, 0 deletions