diff options
| author | Masahiro Yamada <[email protected]> | 2022-06-06 04:53:53 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2022-06-08 17:10:13 +0000 |
| commit | 35b42dce619701f1300fb8498dae82c9bb1f0263 (patch) | |
| tree | 26b240b2ed84cb04df90f0c4e4b72d61b1141aa9 /net/switchdev/switchdev.c | |
| parent | net/mlx4_en: Fix wrong return value on ioctl EEPROM query failure (diff) | |
| download | kernel-35b42dce619701f1300fb8498dae82c9bb1f0263.tar.gz kernel-35b42dce619701f1300fb8498dae82c9bb1f0263.zip | |
net: mdio: unexport __init-annotated mdio_bus_init()
EXPORT_SYMBOL and __init is a bad combination because the .init.text
section is freed up after the initialization. Hence, modules cannot
use symbols annotated __init. The access to a freed symbol may end up
with kernel panic.
modpost used to detect it, but it has been broken for a decade.
Recently, I fixed modpost so it started to warn it again, then this
showed up in linux-next builds.
There are two ways to fix it:
- Remove __init
- Remove EXPORT_SYMBOL
I chose the latter for this case because the only in-tree call-site,
drivers/net/phy/phy_device.c is never compiled as modular.
(CONFIG_PHYLIB is boolean)
Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
Reviewed-by: Russell King (Oracle) <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/switchdev/switchdev.c')
0 files changed, 0 insertions, 0 deletions
