diff options
| author | Florian Fainelli <[email protected]> | 2017-09-28 18:19:06 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2017-10-01 03:01:29 +0000 |
| commit | 21a2774ef5d4fde772fbcb9d0eabb76f585e5af5 (patch) | |
| tree | 524c7150e4b645ac4cb7eac62e0ea55d825e7742 /net/sched/cls_basic.c | |
| parent | Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirshe... (diff) | |
| download | kernel-21a2774ef5d4fde772fbcb9d0eabb76f585e5af5.tar.gz kernel-21a2774ef5d4fde772fbcb9d0eabb76f585e5af5.zip | |
Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable"
This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port
enabling to calling port_enable") because this now makes an unbind
followed by a bind to fail connecting to the ingrated PHY.
What this patch missed is that we need the PHY to be enabled with
bcm_sf2_gphy_enable_set() before probing it on the MDIO bus. This is
correctly done in the ops->setup() function, but by the time
ops->port_enable() runs, this is too late. Upon unbind we would power
down the PHY, and so when we would bind again, the PHY would be left
powered off.
Fixes: e85ec74ace29 ("net: dsa: bcm_sf2: Defer port enabling to calling port_enable")
Signed-off-by: Florian Fainelli <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/sched/cls_basic.c')
0 files changed, 0 insertions, 0 deletions