diff options
| author | Jordan Rife <[email protected]> | 2023-09-21 23:46:42 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2023-10-01 18:31:29 +0000 |
| commit | c889a99a21bf124c3db08d09df919f0eccc5ea4c (patch) | |
| tree | 18c63a51bfbee4af1f62a89a688ba25c7c05697e /net/rds/tcp_connect.c | |
| parent | net: prevent rewrite of msg_name in sock_sendmsg() (diff) | |
| download | kernel-c889a99a21bf124c3db08d09df919f0eccc5ea4c.tar.gz kernel-c889a99a21bf124c3db08d09df919f0eccc5ea4c.zip | |
net: prevent address rewrite in kernel_bind()
Similar to the change in commit 0bdf399342c5("net: Avoid address
overwrite in kernel_connect"), BPF hooks run on bind may rewrite the
address passed to kernel_bind(). This change
1) Makes a copy of the bind address in kernel_bind() to insulate
callers.
2) Replaces direct calls to sock->ops->bind() in net with kernel_bind()
Link: https://lore.kernel.org/netdev/[email protected]/
Fixes: 4fbac77d2d09 ("bpf: Hooks for sys_bind")
Cc: [email protected]
Reviewed-by: Willem de Bruijn <[email protected]>
Signed-off-by: Jordan Rife <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/rds/tcp_connect.c')
| -rw-r--r-- | net/rds/tcp_connect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c index d788c6d28986..a0046e99d6df 100644 --- a/net/rds/tcp_connect.c +++ b/net/rds/tcp_connect.c @@ -145,7 +145,7 @@ int rds_tcp_conn_path_connect(struct rds_conn_path *cp) addrlen = sizeof(sin); } - ret = sock->ops->bind(sock, addr, addrlen); + ret = kernel_bind(sock, addr, addrlen); if (ret) { rdsdebug("bind failed with %d at address %pI6c\n", ret, &conn->c_laddr); |