diff options
| author | Arnd Bergmann <[email protected]> | 2023-02-03 12:15:36 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-02-07 06:33:18 +0000 |
| commit | bbe641866318b2693e2778862e3b8ed6ccd0843b (patch) | |
| tree | a9ca0a2defd372802bb09635b76f148f2af2a615 /net/openvswitch/flow_table.c | |
| parent | net: mscc: ocelot: un-export unused regmap symbols (diff) | |
| download | kernel-bbe641866318b2693e2778862e3b8ed6ccd0843b.tar.gz kernel-bbe641866318b2693e2778862e3b8ed6ccd0843b.zip | |
amd-xgbe: fix mismatched prototype
The forward declaration was introduced with a prototype that does
not match the function definition:
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:2166:13: error: conflicting types for 'xgbe_phy_perform_ratechange' due to enum/integer mismatch; have 'void(struct xgbe_prv_data *, enum xgbe_mb_cmd, enum xgbe_mb_subcmd)' [-Werror=enum-int-mismatch]
2166 | static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:391:13: note: previous declaration of 'xgbe_phy_perform_ratechange' with type 'void(struct xgbe_prv_data *, unsigned int, unsigned int)'
391 | static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Ideally there should not be any forward declarations here, which
would make it easier to show that there is no unbounded recursion.
I tried fixing this but could not figure out how to avoid the
recursive call.
As a hotfix, address only the broken prototype to fix the build
problem instead.
Fixes: 4f3b20bfbb75 ("amd-xgbe: add support for rx-adaptation")
Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Acked-by: Shyam Sundar S K <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/openvswitch/flow_table.c')
0 files changed, 0 insertions, 0 deletions
