diff options
| author | Florian Fainelli <[email protected]> | 2011-06-15 17:15:41 +0000 |
|---|---|---|
| committer | Wim Van Sebroeck <[email protected]> | 2011-06-28 07:42:30 +0000 |
| commit | 2ea4e76e997019ae25ac3417aa46e31ddf7ecb17 (patch) | |
| tree | 347392d5b9cfc8d5fd97c636050b01d1a338ff1a /net/lapb/lapb_iface.c | |
| parent | watchdog: mtx1-wdt: request gpio before using it (diff) | |
| download | kernel-2ea4e76e997019ae25ac3417aa46e31ddf7ecb17.tar.gz kernel-2ea4e76e997019ae25ac3417aa46e31ddf7ecb17.zip | |
watchdog: mtx1-wdt: fix GPIO toggling
Commit e391be76 (MIPS: Alchemy: Clean up GPIO registers and accessors)
changed the way the GPIO was toggled. Prior to this patch, we would
always actively drive the GPIO output to either 0 or 1, this patch
drove the GPIO active to 0, and put the GPIO in tristate to drive it
to 1, unfortunately this does not work, revert back to active driving.
Using a signed variable (gstate) to hold the gpio state and using a bit-
wise operation on it also resulted in toggling value from 1 to -2 since
the variable is signed. This value was then passed on to gpio_direction_
output, which always perform a if (value) ... to set the value to the
gpio, so we were always writing a 1 to this GPIO instead of 1 -> 0 -> 1 ...
Signed-off-by: Florian Fainelli <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>
Cc: stable <[email protected]>
Diffstat (limited to 'net/lapb/lapb_iface.c')
0 files changed, 0 insertions, 0 deletions