diff options
| author | Jakub Kicinski <[email protected]> | 2023-10-26 01:04:31 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-10-26 01:04:31 +0000 |
| commit | d8c4ef76d7ccd478f8c9a3b7de1ba0b25fdffbee (patch) | |
| tree | 9283e779aab9e7621bb9ae824dcadb28f699096e /net/ipv6/tcp_ipv6.c | |
| parent | Merge branch 'mptcp-features-and-fixes-for-v6-7' (diff) | |
| parent | ipv6: avoid atomic fragment on GSO packets (diff) | |
| download | kernel-d8c4ef76d7ccd478f8c9a3b7de1ba0b25fdffbee.tar.gz kernel-d8c4ef76d7ccd478f8c9a3b7de1ba0b25fdffbee.zip | |
Merge branch 'ipv6-avoid-atomic-fragment-on-gso-output'
Yan Zhai says:
====================
ipv6: avoid atomic fragment on GSO output
When the ipv6 stack output a GSO packet, if its gso_size is larger than
dst MTU, then all segments would be fragmented. However, it is possible
for a GSO packet to have a trailing segment with smaller actual size
than both gso_size as well as the MTU, which leads to an "atomic
fragment". Atomic fragments are considered harmful in RFC-8021. An
Existing report from APNIC also shows that atomic fragments are more
likely to be dropped even it is equivalent to a no-op [1].
The series contains following changes:
* drop feature RTAX_FEATURE_ALLFRAG, which has been broken. This helps
simplifying other changes in this set.
* refactor __ip6_finish_output code to separate GSO and non-GSO packet
processing, mirroring IPv4 side logic.
* avoid generating atomic fragment on GSO packets.
Link: https://www.potaroo.net/presentations/2022-03-01-ipv6-frag.pdf [1]
V4: https://lore.kernel.org/netdev/[email protected]/
V3: https://lore.kernel.org/netdev/[email protected]/
V2: https://lore.kernel.org/netdev/ZS1%[email protected]/
====================
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/ipv6/tcp_ipv6.c')
| -rw-r--r-- | net/ipv6/tcp_ipv6.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 0c8a14ba104f..dc27988512a6 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -1895,7 +1895,6 @@ const struct inet_connection_sock_af_ops ipv6_specific = { .conn_request = tcp_v6_conn_request, .syn_recv_sock = tcp_v6_syn_recv_sock, .net_header_len = sizeof(struct ipv6hdr), - .net_frag_header_len = sizeof(struct frag_hdr), .setsockopt = ipv6_setsockopt, .getsockopt = ipv6_getsockopt, .addr2sockaddr = inet6_csk_addr2sockaddr, |