diff options
| author | WANG Cong <[email protected]> | 2017-06-13 20:36:24 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2017-06-14 18:39:19 +0000 |
| commit | 74030603dfd9f76c0f279f19f1dd1ee3028fee7a (patch) | |
| tree | 27b6e967e99232169cadc0420099717f241a38f3 /net/ipv4/tcp_ulp.c | |
| parent | caif: Add sockaddr length check before accessing sa_family in connect handler (diff) | |
| download | kernel-74030603dfd9f76c0f279f19f1dd1ee3028fee7a.tar.gz kernel-74030603dfd9f76c0f279f19f1dd1ee3028fee7a.zip | |
net_sched: move tcf_lock down after gen_replace_estimator()
Laura reported a sleep-in-atomic kernel warning inside
tcf_act_police_init() which calls gen_replace_estimator() with
spinlock protection.
It is not necessary in this case, we already have RTNL lock here
so it is enough to protect concurrent writers. For the reader,
i.e. tcf_act_police(), it needs to make decision based on this
rate estimator, in the worst case we drop more/less packets than
necessary while changing the rate in parallel, it is still acceptable.
Reported-by: Laura Abbott <[email protected]>
Reported-by: Nick Huber <[email protected]>
Cc: Jamal Hadi Salim <[email protected]>
Signed-off-by: Cong Wang <[email protected]>
Acked-by: Jamal Hadi Salim <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/ipv4/tcp_ulp.c')
0 files changed, 0 insertions, 0 deletions