diff options
| author | Fabio Estevam <[email protected]> | 2014-09-22 20:55:29 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2014-09-26 19:39:59 +0000 |
| commit | aebac744932439b5f869869f07f406a9cced465d (patch) | |
| tree | ee80643e5dd8e156ad23b492874f5409cd44f1e9 /net/ipv4/tcp_output.c | |
| parent | Merge tag 'master-2014-09-16' of git://git.kernel.org/pub/scm/linux/kernel/gi... (diff) | |
| download | kernel-aebac744932439b5f869869f07f406a9cced465d.tar.gz kernel-aebac744932439b5f869869f07f406a9cced465d.zip | |
fec: Remove fec_enet_select_queue()
Sparse complains about fec_enet_select_queue() not being static.
Feedback from David Miller [1] was to remove this function instead of making it
static:
"Please just delete this function.
It's overriding code which does exactly the same thing.
Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking. For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.
Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen."
[1] http://www.spinics.net/lists/netdev/msg297653.html
Signed-off-by: Fabio Estevam <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/ipv4/tcp_output.c')
0 files changed, 0 insertions, 0 deletions
