diff options
| author | Kuniyuki Iwashima <[email protected]> | 2022-07-13 20:52:04 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2022-07-15 10:49:56 +0000 |
| commit | 92c0aa4175474483d6cf373314343d4e624e882a (patch) | |
| tree | ac866e910a3ac09ff6795782a0582697db17dcfb /net/ipv4/tcp_output.c | |
| parent | tcp: Fix a data-race around sysctl_tcp_mtu_probe_floor. (diff) | |
| download | kernel-92c0aa4175474483d6cf373314343d4e624e882a.tar.gz kernel-92c0aa4175474483d6cf373314343d4e624e882a.zip | |
tcp: Fix a data-race around sysctl_tcp_probe_threshold.
While reading sysctl_tcp_probe_threshold, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 6b58e0a5f32d ("ipv4: Use binary search to choose tcp PMTU probe_size")
Signed-off-by: Kuniyuki Iwashima <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 7130b405da21..aa757c74dad4 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -2367,7 +2367,7 @@ static int tcp_mtu_probe(struct sock *sk) * probing process by not resetting search range to its orignal. */ if (probe_size > tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_high) || - interval < net->ipv4.sysctl_tcp_probe_threshold) { + interval < READ_ONCE(net->ipv4.sysctl_tcp_probe_threshold)) { /* Check whether enough time has elaplased for * another round of probing. */ |