diff options
| author | Trond Myklebust <[email protected]> | 2007-04-20 20:12:55 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2007-04-21 05:56:30 +0000 |
| commit | 241c39b9ac4bf847013aa06cce6d4d61426a2006 (patch) | |
| tree | 6455884e65288e64576555a27c06a8ee2f1f6371 /net/ipv4/tcp_input.c | |
| parent | NFS: Fix race in nfs_set_page_dirty (diff) | |
| download | kernel-241c39b9ac4bf847013aa06cce6d4d61426a2006.tar.gz kernel-241c39b9ac4bf847013aa06cce6d4d61426a2006.zip | |
RPC: Fix the TCP resend semantics for NFSv4
Fix a regression due to the patch "NFS: disconnect before retrying NFSv4
requests over TCP"
The assumption made in xprt_transmit() that the condition
"req->rq_bytes_sent == 0 and request is on the receive list"
should imply that we're dealing with a retransmission is false.
Firstly, it may simply happen that the socket send queue was full
at the time the request was initially sent through xprt_transmit().
Secondly, doing this for each request that was retransmitted implies
that we disconnect and reconnect for _every_ request that happened to
be retransmitted irrespective of whether or not a disconnection has
already occurred.
Fix is to move this logic into the call_status request timeout handler.
Signed-off-by: Trond Myklebust <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'net/ipv4/tcp_input.c')
0 files changed, 0 insertions, 0 deletions