diff options
| author | Breno Leitao <[email protected]> | 2024-07-24 08:05:23 +0000 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2024-07-25 09:24:03 +0000 |
| commit | 16f3a28cf5f876a7f3550d8f4c870a7b41bcfaef (patch) | |
| tree | 3663e35a1cd909e43fb4b8c86c973ef98845915a /net/ipv4/tcp_input.c | |
| parent | Merge tag 'nf-24-07-24' of git://git.kernel.org/pub/scm/linux/kernel/git/netf... (diff) | |
| download | kernel-16f3a28cf5f876a7f3550d8f4c870a7b41bcfaef.tar.gz kernel-16f3a28cf5f876a7f3550d8f4c870a7b41bcfaef.zip | |
net: mediatek: Fix potential NULL pointer dereference in dummy net_device handling
Move the freeing of the dummy net_device from mtk_free_dev() to
mtk_remove().
Previously, if alloc_netdev_dummy() failed in mtk_probe(),
eth->dummy_dev would be NULL. The error path would then call
mtk_free_dev(), which in turn called free_netdev() assuming dummy_dev
was allocated (but it was not), potentially causing a NULL pointer
dereference.
By moving free_netdev() to mtk_remove(), we ensure it's only called when
mtk_probe() has succeeded and dummy_dev is fully allocated. This
addresses a potential NULL pointer dereference detected by Smatch[1].
Fixes: b209bd6d0bff ("net: mediatek: mtk_eth_sock: allocate dummy net_device dynamically")
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/ [1]
Suggested-by: Dan Carpenter <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Breno Leitao <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Diffstat (limited to 'net/ipv4/tcp_input.c')
0 files changed, 0 insertions, 0 deletions