diff options
| author | Eric Dumazet <[email protected]> | 2025-04-07 16:35:59 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-04-08 19:30:55 +0000 |
| commit | c3025e94daa9ce84ef0e53df983b5bf2fbd76ea6 (patch) | |
| tree | ae27369d8f8e2ba0f96e7038fa7a996d7d9c8d28 /net/core/dev.h | |
| parent | amd-xgbe: Convert to SPDX identifier (diff) | |
| download | kernel-c3025e94daa9ce84ef0e53df983b5bf2fbd76ea6.tar.gz kernel-c3025e94daa9ce84ef0e53df983b5bf2fbd76ea6.zip | |
net: rps: change skb_flow_limit() hash function
As explained in commit f3483c8e1da6 ("net: rfs: hash function change"),
masking low order bits of skb_get_hash(skb) has low entropy.
A NIC with 32 RX queues uses the 5 low order bits of rss key
to select a queue. This means all packets landing to a given
queue share the same 5 low order bits.
Switch to hash_32() to reduce hash collisions.
Signed-off-by: Eric Dumazet <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/core/dev.h')
| -rw-r--r-- | net/core/dev.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.h b/net/core/dev.h index 7ee203395d8e..b1cd44b5f009 100644 --- a/net/core/dev.h +++ b/net/core/dev.h @@ -16,7 +16,7 @@ struct cpumask; #define FLOW_LIMIT_HISTORY (1 << 7) /* must be ^2 and !overflow buckets */ struct sd_flow_limit { u64 count; - unsigned int num_buckets; + u8 log_buckets; unsigned int history_head; u16 history[FLOW_LIMIT_HISTORY]; u8 buckets[]; |