diff options
| author | Florian Westphal <[email protected]> | 2025-08-20 12:37:07 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-08-21 17:02:00 +0000 |
| commit | 91a79b792204313153e1bdbbe5acbfc28903b3a5 (patch) | |
| tree | 3215a927e2c44ce39e4252555413d081f73f3e0c /net/core/dev.c | |
| parent | Merge branch 'mlx5-misx-fixes-2025-08-20' (diff) | |
| download | kernel-91a79b792204313153e1bdbbe5acbfc28903b3a5.tar.gz kernel-91a79b792204313153e1bdbbe5acbfc28903b3a5.zip | |
netfilter: nf_reject: don't leak dst refcount for loopback packets
recent patches to add a WARN() when replacing skb dst entry found an
old bug:
WARNING: include/linux/skbuff.h:1165 skb_dst_check_unset include/linux/skbuff.h:1164 [inline]
WARNING: include/linux/skbuff.h:1165 skb_dst_set include/linux/skbuff.h:1210 [inline]
WARNING: include/linux/skbuff.h:1165 nf_reject_fill_skb_dst+0x2a4/0x330 net/ipv4/netfilter/nf_reject_ipv4.c:234
[..]
Call Trace:
nf_send_unreach+0x17b/0x6e0 net/ipv4/netfilter/nf_reject_ipv4.c:325
nft_reject_inet_eval+0x4bc/0x690 net/netfilter/nft_reject_inet.c:27
expr_call_ops_eval net/netfilter/nf_tables_core.c:237 [inline]
..
This is because blamed commit forgot about loopback packets.
Such packets already have a dst_entry attached, even at PRE_ROUTING stage.
Instead of checking hook just check if the skb already has a route
attached to it.
Fixes: f53b9b0bdc59 ("netfilter: introduce support for reject at prerouting stage")
Signed-off-by: Florian Westphal <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/core/dev.c')
0 files changed, 0 insertions, 0 deletions