diff options
| author | Chi Zhiling <[email protected]> | 2025-06-05 05:49:35 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2025-07-10 05:41:59 +0000 |
| commit | bbcaee20e03ecaeeecba32a703816a0d4502b6c4 (patch) | |
| tree | 2502cf4dc620c623eaa7962fa7d2e247304129e8 /mm/filemap.c | |
| parent | mm/cma: pair the trace_cma_alloc_start/finish (diff) | |
| download | kernel-bbcaee20e03ecaeeecba32a703816a0d4502b6c4.tar.gz kernel-bbcaee20e03ecaeeecba32a703816a0d4502b6c4.zip | |
readahead: fix return value of page_cache_next_miss() when no hole is found
max_scan in page_cache_next_miss always decreases to zero when no hole is
found, causing the return value to be index + 0.
Fix this by preserving the max_scan value throughout the loop.
Jan said "From what I know and have seen in the past, wrong responses
from page_cache_next_miss() can lead to readahead window reduction and
thus reduced read speeds."
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 901a269ff3d5 ("filemap: fix page_cache_next_miss() when no hole found")
Signed-off-by: Chi Zhiling <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Cc: Josef Bacik <[email protected]>
Cc: Matthew Wilcox (Oracle) <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'mm/filemap.c')
| -rw-r--r-- | mm/filemap.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mm/filemap.c b/mm/filemap.c index bada249b9fb7..a6459874bb2a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1778,8 +1778,9 @@ pgoff_t page_cache_next_miss(struct address_space *mapping, pgoff_t index, unsigned long max_scan) { XA_STATE(xas, &mapping->i_pages, index); + unsigned long nr = max_scan; - while (max_scan--) { + while (nr--) { void *entry = xas_next(&xas); if (!entry || xa_is_value(entry)) return xas.xa_index; |