diff options
| author | Baokun Li <[email protected]> | 2024-01-24 14:28:56 +0000 |
|---|---|---|
| committer | Christian Brauner <[email protected]> | 2024-01-25 16:23:51 +0000 |
| commit | 4b944f8ef99641d5af287c7d9df91d20ef5d3e88 (patch) | |
| tree | 0d9f1f456dcc8face557e9652b47dafa7ff19049 /mm/filemap.c | |
| parent | fs: make the i_size_read/write helpers be smp_load_acquire/store_release() (diff) | |
| download | kernel-4b944f8ef99641d5af287c7d9df91d20ef5d3e88.tar.gz kernel-4b944f8ef99641d5af287c7d9df91d20ef5d3e88.zip | |
Revert "mm/filemap: avoid buffered read/write race to read inconsistent data"
This reverts commit e2c27b803bb6 ("mm/filemap: avoid buffered read/write
race to read inconsistent data"). After making the i_size_read/write
helpers be smp_load_acquire/store_release(), it is already guaranteed that
changes to page contents are visible before we see increased inode size,
so the extra smp_rmb() in filemap_read() can be removed.
Signed-off-by: Baokun Li <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Christian Brauner <[email protected]>
Diffstat (limited to 'mm/filemap.c')
| -rw-r--r-- | mm/filemap.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/mm/filemap.c b/mm/filemap.c index 750e779c23db..a72dd2eafd5a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2609,15 +2609,6 @@ ssize_t filemap_read(struct kiocb *iocb, struct iov_iter *iter, end_offset = min_t(loff_t, isize, iocb->ki_pos + iter->count); /* - * Pairs with a barrier in - * block_write_end()->mark_buffer_dirty() or other page - * dirtying routines like iomap_write_end() to ensure - * changes to page contents are visible before we see - * increased inode size. - */ - smp_rmb(); - - /* * Once we start copying data, we don't want to be touching any * cachelines that might be contended: */ |