diff options
| author | Yosry Ahmed <[email protected]> | 2024-04-13 02:24:07 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2024-05-06 00:53:38 +0000 |
| commit | c074e1467f8546c8f8c9ea2128fb8bf8c4579418 (patch) | |
| tree | 2878eb9a7f99a55c2a7ddd4a7c36c05446e2988e /lib/xarray.c | |
| parent | mm: zswap: move more same-filled pages checks outside of zswap_store() (diff) | |
| download | kernel-c074e1467f8546c8f8c9ea2128fb8bf8c4579418.tar.gz kernel-c074e1467f8546c8f8c9ea2128fb8bf8c4579418.zip | |
mm: zswap: remove same_filled module params
These knobs offer more fine-grained control to userspace than needed and
directly expose/influence kernel implementation; remove them.
For disabling same_filled handling, there is no logical reason to refuse
storing same-filled pages more efficiently and opt for compression.
Scanning pages for patterns may be an argument, but the page contents will
be read into the CPU cache anyway during compression. Also, removing the
same_filled handling code does not move the needle significantly in terms
of performance anyway [1].
For disabling non_same_filled handling, it was added when the compressed
pages in zswap were not being properly charged to memcgs, as workloads
could escape the accounting with compression [2]. This is no longer the
case after commit f4840ccfca25 ("zswap: memcg accounting"), and using
zswap without compression does not make much sense.
[1]https://lore.kernel.org/lkml/CAJD7tkaySFP2hBQw4pnZHJJwe3bMdjJ1t9VC2VJd=khn1_TXvA@mail.gmail.com/
[2]https://lore.kernel.org/lkml/[email protected]/
[[email protected]: remove same_filled_pages from docs]
Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Yosry Ahmed <[email protected]>
Acked-by: Johannes Weiner <[email protected]>
Reviewed-by: Nhat Pham <[email protected]>
Reviewed-by: Chengming Zhou <[email protected]>
Cc: "Maciej S. Szmigiero" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'lib/xarray.c')
0 files changed, 0 insertions, 0 deletions
