diff options
| author | Fangrui Song <[email protected]> | 2022-03-22 01:26:17 +0000 |
|---|---|---|
| committer | Palmer Dabbelt <[email protected]> | 2022-03-29 21:31:07 +0000 |
| commit | 60210a3d86dc57ce4a76a366e7841dda746a33f7 (patch) | |
| tree | 771dd9a723bf41feb498b6fb93cf460003e2715b /lib/xarray.c | |
| parent | Merge tag 'riscv-for-linus-5.18-mw0' of git://git.kernel.org/pub/scm/linux/ke... (diff) | |
| download | kernel-60210a3d86dc57ce4a76a366e7841dda746a33f7.tar.gz kernel-60210a3d86dc57ce4a76a366e7841dda746a33f7.zip | |
riscv module: remove (NOLOAD)
On ELF, (NOLOAD) sets the section type to SHT_NOBITS[1]. It is conceptually
inappropriate for .plt, .got, and .got.plt sections which are always
SHT_PROGBITS.
In GNU ld, if PLT entries are needed, .plt will be SHT_PROGBITS anyway
and (NOLOAD) will be essentially ignored. In ld.lld, since
https://reviews.llvm.org/D118840 ("[ELF] Support (TYPE=<value>) to
customize the output section type"), ld.lld will report a `section type
mismatch` error (later changed to a warning). Just remove (NOLOAD) to
fix the warning.
[1] https://lld.llvm.org/ELF/linker_script.html As of today, "The
section should be marked as not loadable" on
https://sourceware.org/binutils/docs/ld/Output-Section-Type.html is
outdated for ELF.
Link: https://github.com/ClangBuiltLinux/linux/issues/1597
Fixes: ab1ef68e5401 ("RISC-V: Add sections of PLT and GOT for kernel module")
Reported-by: Nathan Chancellor <[email protected]>
Signed-off-by: Fangrui Song <[email protected]>
Signed-off-by: Palmer Dabbelt <[email protected]>
Diffstat (limited to 'lib/xarray.c')
0 files changed, 0 insertions, 0 deletions