diff options
| author | Ewan D. Milne <[email protected]> | 2025-11-10 21:20:00 +0000 |
|---|---|---|
| committer | Keith Busch <[email protected]> | 2025-11-17 17:00:42 +0000 |
| commit | ea3442efabd0aa3930c5bab73c3901ef38ef6ac3 (patch) | |
| tree | 4add59c9d2dfa57b6a9d49587d08b6ed9d58b1cf /lib/test_fortify/write_overflow-strlcpy-src.c | |
| parent | nvme-multipath: fix lockdep WARN due to partition scan work (diff) | |
| download | kernel-ea3442efabd0aa3930c5bab73c3901ef38ef6ac3.tar.gz kernel-ea3442efabd0aa3930c5bab73c3901ef38ef6ac3.zip | |
nvme: nvme-fc: move tagset removal to nvme_fc_delete_ctrl()
Now target is removed from nvme_fc_ctrl_free() which is the ctrl->ref
release handler. And even admin queue is unquiesced there, this way
is definitely wrong because the ctr->ref is grabbed when submitting
command.
And Marco observed that nvme_fc_ctrl_free() can be called from request
completion code path, and trigger kernel warning since request completes
from softirq context.
Fix the issue by moveing target removal into nvme_fc_delete_ctrl(),
which is also aligned with nvme-tcp and nvme-rdma.
Patch originally proposed by Ming Lei, then modified to move the tagset
removal down to after nvme_fc_delete_association() after further testing.
Cc: Marco Patalano <[email protected]>
Cc: Ewan Milne <[email protected]>
Cc: James Smart <[email protected]>
Cc: Sagi Grimberg <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Cc: [email protected]
Tested-by: Marco Patalano <[email protected]>
Reviewed-by: Justin Tee <[email protected]>
Signed-off-by: Ewan D. Milne <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strlcpy-src.c')
0 files changed, 0 insertions, 0 deletions