diff options
| author | Avichal Rakesh <[email protected]> | 2024-01-04 21:50:09 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2024-01-05 09:35:57 +0000 |
| commit | 9866dc4314c6c858e451933f965d64532aec00a9 (patch) | |
| tree | 96aeb09937340fe72fc765dc635f43498e9f63c8 /lib/test_fortify/write_overflow-strlcpy-src.c | |
| parent | usb: gadget: uvc: Fix use are free during STREAMOFF (diff) | |
| download | kernel-9866dc4314c6c858e451933f965d64532aec00a9.tar.gz kernel-9866dc4314c6c858e451933f965d64532aec00a9.zip | |
usb: gadget: uvc: Remove nested locking
When handling error status from uvcg_video_usb_req_queue,
uvc_video_complete currently calls uvcg_queue_cancel with
video->req_lock held. uvcg_queue_cancel internally locks
queue->irqlock, which nests queue->irqlock inside
video->req_lock. This isn't a functional bug at the
moment, but does open up possibilities for ABBA
deadlocks in the future.
This patch fixes the accidental nesting by dropping
video->req_lock before calling uvcg_queue_cancel.
Fixes: 6acba0345b68 ("usb:gadget:uvc Do not use worker thread to pump isoc usb requests")
Signed-off-by: Avichal Rakesh <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strlcpy-src.c')
0 files changed, 0 insertions, 0 deletions