aboutsummaryrefslogtreecommitdiffstats
path: root/lib/string_helpers.c
diff options
context:
space:
mode:
authorArnd Bergmann <[email protected]>2017-09-13 23:28:23 +0000
committerLinus Torvalds <[email protected]>2017-09-14 01:53:15 +0000
commitebfddb3d447f5267c76680ea4d242e6f9bcafa87 (patch)
treee3b10c4586e31933b9e157328b7952ce1bd95175 /lib/string_helpers.c
parentlib/test_bitmap.c: use ULL suffix for 64-bit constants (diff)
downloadkernel-ebfddb3d447f5267c76680ea4d242e6f9bcafa87.tar.gz
kernel-ebfddb3d447f5267c76680ea4d242e6f9bcafa87.zip
fscache: fix fscache_objlist_show format processing
gcc points out a minor bug in the handling of unknown cookie types, which could result in a string overflow when the integer is copied into a 3-byte string: fs/fscache/object-list.c: In function 'fscache_objlist_show': fs/fscache/object-list.c:265:19: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] sprintf(_type, "%02u", cookie->def->type); ^~~~~~ fs/fscache/object-list.c:265:4: note: 'sprintf' output between 3 and 4 bytes into a destination of size 3 This is currently harmless as no code sets a type other than 0 or 1, but it makes sense to use snprintf() here to avoid overflowing the array if that changes. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions