diff options
| author | James Smart <[email protected]> | 2018-03-07 23:59:36 +0000 |
|---|---|---|
| committer | Keith Busch <[email protected]> | 2018-03-08 17:39:58 +0000 |
| commit | d157e5343cb360a525e6b3e7924612a9a90df3b7 (patch) | |
| tree | cdf67d4de812be44eb63121a116b14ef3e9d8c80 /lib/string_helpers.c | |
| parent | nvme-fabrics: Ignore nr_io_queues option for discovery controllers (diff) | |
| download | kernel-d157e5343cb360a525e6b3e7924612a9a90df3b7.tar.gz kernel-d157e5343cb360a525e6b3e7924612a9a90df3b7.zip | |
nvme_fc: rework sqsize handling
Corrected four outstanding issues in the transport around sqsize.
1: Create Connection LS is sending the 1's-based sqsize, should be
sending the 0's-based value.
2: allocation of hw queue is using the 0's-base size. It should be
using the 1's-based value.
3: normalization of ctrl.sqsize by MQES is using MQES+1 (1's-based
value). It should be MQES (0's-based value).
4: Missing clause to ensure queue_count not larger than ctrl->sqsize.
Corrected by:
Clean up routines that pass queue size around. The queue size value is
the actual count (1's-based) value and determined from ctrl->sqsize + 1.
Routines that send 0's-based value adapt from queue size.
Sset ctrl->sqsize properly for MQES.
Added clause to nsure queue_count not larger than ctrl->sqsize + 1.
Signed-off-by: James Smart <[email protected]>
Reviewed-by: Sagi Grimberg <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions
