diff options
| author | Puyou Lu <[email protected]> | 2022-05-13 03:38:36 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2022-05-13 03:38:36 +0000 |
| commit | cd290a9839cee2f6641558877e707bd373c8f6f1 (patch) | |
| tree | 63d4da0003125bbdfe2af14f9f627de4056ba6ea /lib/string_helpers.c | |
| parent | kernel/crash_core.c: remove redundant check of ck_cmdline (diff) | |
| download | kernel-cd290a9839cee2f6641558877e707bd373c8f6f1.tar.gz kernel-cd290a9839cee2f6641558877e707bd373c8f6f1.zip | |
lib/string_helpers: fix not adding strarray to device's resource list
Add allocated strarray to device's resource list. This is a must to
automatically release strarray when the device disappears.
Without this fix we have a memory leak in the few drivers which use
devm_kasprintf_strarray().
Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Fixes: acdb89b6c87a ("lib/string_helpers: Introduce managed variant of kasprintf_strarray()")
Signed-off-by: Puyou Lu <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
| -rw-r--r-- | lib/string_helpers.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/string_helpers.c b/lib/string_helpers.c index 4f877e9551d5..5ed3beb066e6 100644 --- a/lib/string_helpers.c +++ b/lib/string_helpers.c @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n) return ERR_PTR(-ENOMEM); } + ptr->n = n; + devres_add(dev, ptr); + return ptr->array; } EXPORT_SYMBOL_GPL(devm_kasprintf_strarray); |