diff options
| author | Mikulas Patocka <[email protected]> | 2019-03-21 20:46:12 +0000 |
|---|---|---|
| committer | Mike Snitzer <[email protected]> | 2019-04-01 20:20:36 +0000 |
| commit | 75ae193626de3238ca5fb895868ec91c94e63b1b (patch) | |
| tree | 03bbd7c98d4a514e69b71d17eeb2916d172db0e5 /lib/string_helpers.c | |
| parent | dm init: fix const confusion for dm_allowed_targets array (diff) | |
| download | kernel-75ae193626de3238ca5fb895868ec91c94e63b1b.tar.gz kernel-75ae193626de3238ca5fb895868ec91c94e63b1b.zip | |
dm: revert 8f50e358153d ("dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE")
The limit was already incorporated to dm-crypt with commit 4e870e948fba
("dm crypt: fix error with too large bios"), so we don't need to apply
it globally to all targets. The quantity BIO_MAX_PAGES * PAGE_SIZE is
wrong anyway because the variable ti->max_io_len it is supposed to be in
the units of 512-byte sectors not in bytes.
Reduction of the limit to 1048576 sectors could even cause data
corruption in rare cases - suppose that we have a dm-striped device with
stripe size 768MiB. The target will call dm_set_target_max_io_len with
the value 1572864. The buggy code would reduce it to 1048576. Now, the
dm-core will errorneously split the bios on 1048576-sector boundary
insetad of 1572864-sector boundary and pass these stripe-crossing bios
to the striped target.
Cc: [email protected] # v4.16+
Fixes: 8f50e358153d ("dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE")
Signed-off-by: Mikulas Patocka <[email protected]>
Acked-by: Ming Lei <[email protected]>
Signed-off-by: Mike Snitzer <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions