diff options
| author | James Smart <[email protected]> | 2008-08-08 00:49:30 +0000 |
|---|---|---|
| committer | James Bottomley <[email protected]> | 2008-10-03 16:46:12 +0000 |
| commit | 315cb0ad124575e75da2d0e0a95990587fc23485 (patch) | |
| tree | 1efbc6b9b744163bb542ea3eec87bdb4786b598a /lib/string_helpers.c | |
| parent | e1000e: update version from k4 to k6 (diff) | |
| download | kernel-315cb0ad124575e75da2d0e0a95990587fc23485.tar.gz kernel-315cb0ad124575e75da2d0e0a95990587fc23485.zip | |
[SCSI] scsi_host_lookup: error returns and NULL pointers
This patch cleans up the behavior of scsi_host_lookup().
The original implementation attempted to use the dual role of
either returning a pointer value, or a negative error code.
User's needed to use IS_ERR() to check the result. Additionally,
the IS_ERR() macro never checks for when a NULL pointer was
returned, so a NULL pointer actually passes with a success case.
Note: scsi_host_get(), used by scsi_host_lookup(), can return
a NULL pointer.
Talk about a mudhole for the unitiated to step into....
This patch converts scsi_host_lookup() to return either NULL
or a valid pointer. The consumers were updated for the change.
Signed-off-by: James Smart <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions