diff options
| author | Nicholas Bellinger <[email protected]> | 2012-03-14 01:20:11 +0000 |
|---|---|---|
| committer | Nicholas Bellinger <[email protected]> | 2012-03-14 04:43:58 +0000 |
| commit | 00fdc6bbef77844ce397a7de7acfaf25e8e2e4eb (patch) | |
| tree | df8d71a6b9c9239b68d43fc04d57580caf3e4992 /lib/string.c | |
| parent | target: Fix compatible reservation handling (CRH=1) with legacy RESERVE/RELEASE (diff) | |
| download | kernel-00fdc6bbef77844ce397a7de7acfaf25e8e2e4eb.tar.gz kernel-00fdc6bbef77844ce397a7de7acfaf25e8e2e4eb.zip | |
iscsi-target: Fix reservation conflict -EBUSY response handling bug
This patch addresses a iscsi-target specific bug related to reservation conflict
handling in iscsit_handle_scsi_cmd() that has been causing reservation conflicts
to complete and not fail as expected due to incorrect errno checking. The problem
occured with the change to return -EBUSY from transport_generic_cmd_sequencer() ->
transport_generic_allocate_tasks() failures, that broke iscsit_handle_scsi_cmd()
checking for -EINVAL in order to invoke a non GOOD status response.
This was manifesting itself as data corruption with legacy SPC-2 reservations,
but also effects iscsi-target LUNs with SPC-3 persistent reservations.
This bug was originally introduced in lio-core commit:
commit 03e98c9eb916f3f0868c1dc344dde2a60287ff72
Author: Nicholas Bellinger <[email protected]>
Date: Fri Nov 4 02:36:16 2011 -0700
target: Address legacy PYX_TRANSPORT_* return code breakage
Reported-by: Martin Svec <[email protected]>
Cc: Martin Svec <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: [email protected]
Signed-off-by: Nicholas Bellinger <[email protected]>
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions