diff options
| author | Prabhakar Lad <[email protected]> | 2017-07-20 08:56:31 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2017-07-26 10:14:33 +0000 |
| commit | b25db383928cecba356835583b16fa7008f97b3a (patch) | |
| tree | ef1c2b99a568ff3fd83e0eabb3a4fb0f109f441f /lib/raid6/algos.c | |
| parent | media: platform: davinci: return -EINVAL for VPFE_CMD_S_CCDC_RAW_PARAMS ioctl (diff) | |
| download | kernel-b25db383928cecba356835583b16fa7008f97b3a.tar.gz kernel-b25db383928cecba356835583b16fa7008f97b3a.zip | |
media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS
drop VPFE_CMD_S_CCDC_RAW_PARAMS ioctl from dm355/dm644x following reasons:
- This ioctl was never in public api and was only defined in kernel header.
- The function set_params constantly mixes up pointers and phys_addr_t
numbers.
- This is part of a 'VPFE_CMD_S_CCDC_RAW_PARAMS' ioctl command that is
described as an 'experimental ioctl that will change in future kernels'.
- The code to allocate the table never gets called after we copy_from_user
the user input over the kernel settings, and then compare them
for inequality.
- We then go on to use an address provided by user space as both the
__user pointer for input and pass it through phys_to_virt to come up
with a kernel pointer to copy the data to. This looks like a trivially
exploitable root hole.
Signed-off-by: Lad, Prabhakar <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'lib/raid6/algos.c')
0 files changed, 0 insertions, 0 deletions
