diff options
| author | Hans Verkuil <[email protected]> | 2021-06-30 07:58:23 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2021-07-30 11:01:03 +0000 |
| commit | c592b46907adbeb81243f7eb7a468c36692658b8 (patch) | |
| tree | 3d0a70b8779e798f5d2fa9a236953121d5318cfe /lib/netdev-notifier-error-inject.c | |
| parent | media: rtl28xxu: fix zero-length control request (diff) | |
| download | kernel-c592b46907adbeb81243f7eb7a468c36692658b8.tar.gz kernel-c592b46907adbeb81243f7eb7a468c36692658b8.zip | |
media: videobuf2-core: dequeue if start_streaming fails
If a vb2_queue sets q->min_buffers_needed then when the number of
queued buffers reaches q->min_buffers_needed, vb2_core_qbuf() will call
the start_streaming() callback. If start_streaming() returns an error,
then that error was just returned by vb2_core_qbuf(), but the buffer
was still queued. However, userspace expects that if VIDIOC_QBUF fails,
the buffer is returned dequeued.
So if start_streaming() fails, then remove the buffer from the queue,
thus avoiding this unwanted side-effect.
Signed-off-by: Hans Verkuil <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Tested-by: Kieran Bingham <[email protected]>
Fixes: b3379c6201bb ("[media] vb2: only call start_streaming if sufficient buffers are queued")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'lib/netdev-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions