aboutsummaryrefslogtreecommitdiffstats
path: root/lib/netdev-notifier-error-inject.c
diff options
context:
space:
mode:
authorYonghong Song <[email protected]>2025-01-18 19:20:24 +0000
committerAlexei Starovoitov <[email protected]>2025-01-20 17:43:29 +0000
commitaefaa4313b5083427781f9e3e0cc7b5ce5cb4df0 (patch)
tree0f83d0e97cbf3a96de41e4e9a25d362b565f92c6 /lib/netdev-notifier-error-inject.c
parentMerge branch 'free-htab-element-out-of-bucket-lock' (diff)
downloadkernel-aefaa4313b5083427781f9e3e0cc7b5ce5cb4df0.tar.gz
kernel-aefaa4313b5083427781f9e3e0cc7b5ce5cb4df0.zip
bpf: Allow 'may_goto 0' instruction in verifier
Commit 011832b97b31 ("bpf: Introduce may_goto instruction") added support for may_goto insn. The 'may_goto 0' insn is disallowed since the insn is equivalent to a nop as both branch will go to the next insn. But it is possible that compiler transformation may generate 'may_goto 0' insn. Emil Tsalapatis from Meta reported such a case which caused verification failure. For example, for the following code, int i, tmp[3]; for (i = 0; i < 3 && can_loop; i++) tmp[i] = 0; ... clang 20 may generate code like may_goto 2; may_goto 1; may_goto 0; r1 = 0; /* tmp[0] = 0; */ r2 = 0; /* tmp[1] = 0; */ r3 = 0; /* tmp[2] = 0; */ Let us permit 'may_goto 0' insn to avoid verification failure for codes like the above. Reported-by: Emil Tsalapatis <[email protected]> Acked-by: Eduard Zingerman <[email protected]> Signed-off-by: Yonghong Song <[email protected]> Acked-by: Daniel Borkmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexei Starovoitov <[email protected]>
Diffstat (limited to 'lib/netdev-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions