diff options
| author | Eric Biggers <[email protected]> | 2025-10-22 03:34:05 +0000 |
|---|---|---|
| committer | Eric Biggers <[email protected]> | 2025-10-22 17:52:10 +0000 |
| commit | 1af424b15401d2be789c4dc2279889514e7c5c94 (patch) | |
| tree | 2c8d48d551d1a4cdddde782b389de6c78574dc8d /lib/mpi/mpi-mod.c | |
| parent | Linux 6.18-rc2 (diff) | |
| download | kernel-1af424b15401d2be789c4dc2279889514e7c5c94.tar.gz kernel-1af424b15401d2be789c4dc2279889514e7c5c94.zip | |
lib/crypto: poly1305: Restore dependency of arch code on !KMSAN
Restore the dependency of the architecture-optimized Poly1305 code on
!KMSAN. It was dropped by commit b646b782e522 ("lib/crypto: poly1305:
Consolidate into single module").
Unlike the other hash algorithms in lib/crypto/ (e.g., SHA-512), the way
the architecture-optimized Poly1305 code is integrated results in
assembly code initializing memory, for several different architectures.
Thus, it generates false positive KMSAN warnings. These could be
suppressed with kmsan_unpoison_memory(), but it would be needed in quite
a few places. For now let's just restore the dependency on !KMSAN.
Note: this should have been caught by running poly1305_kunit with
CONFIG_KMSAN=y, which I did. However, due to an unrelated KMSAN bug
(https://lore.kernel.org/r/20251022030213.GA35717@sol/), KMSAN currently
isn't working reliably. Thus, the warning wasn't noticed until later.
Fixes: b646b782e522 ("lib/crypto: poly1305: Consolidate into single module")
Reported-by: [email protected]
Closes: https://lore.kernel.org/r/[email protected]/
Reported-by: Pei Xiao <[email protected]>
Closes: https://lore.kernel.org/r/751b3d80293a6f599bb07770afcef24f623c7da0.1761026343.git.xiaopei01@kylinos.cn/
Reviewed-by: Ard Biesheuvel <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Eric Biggers <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-mod.c')
0 files changed, 0 insertions, 0 deletions
