diff options
| author | Tamir Duberstein <[email protected]> | 2024-12-04 18:41:06 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2025-01-13 04:21:00 +0000 |
| commit | 3735c5225b97cb57745afd151904d08847b09cc7 (patch) | |
| tree | e954a15221435a66e86e9762919243868d1972e0 /lib/fault-inject.c | |
| parent | ucounts: move kfree() out of critical zone protected by ucounts_lock (diff) | |
| download | kernel-3735c5225b97cb57745afd151904d08847b09cc7.tar.gz kernel-3735c5225b97cb57745afd151904d08847b09cc7.zip | |
checkpatch: check return of `git_commit_info`
Avoid string concatenation with an undefined variable when a reference to
a missing commit is contained in a `Fixes` tag.
Given this patch:
: From: Tamir Duberstein <[email protected]>
: Subject: Test patch
: Date: Fri, 25 Oct 2024 19:30:51 -0400
:
: This is a test patch.
:
: Fixes: deadbeef111
: Signed-off-by: Tamir Duberstein <[email protected]>
: --- /dev/null
: +++ b/new-file
: @@ -0,0 +1 @@
: +Test.
Before:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: ("commit title")'
WARNING: Unknown commit id 'deadbeef111', maybe rebased or not pulled?
Use of uninitialized value $cid in concatenation (.) or string at scripts/checkpatch.pl line 3242.
After:
WARNING: Unknown commit id 'deadbeef111', maybe rebased or not pulled?
This patch also reduce duplication slightly.
[[email protected]: s/12 chars of sha1/12+ chars of sha1/, per Jon]
Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Tamir Duberstein <[email protected]>
Cc: Andy Whitcroft <[email protected]>
Cc: Dwaipayan Ray <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Lukas Bulwahn <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'lib/fault-inject.c')
0 files changed, 0 insertions, 0 deletions