diff options
| author | Jim Cromie <[email protected]> | 2022-09-04 21:40:39 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-09-07 14:58:23 +0000 |
| commit | 85d6b66d31c35158364058ee98fb69ab5bb6a6b1 (patch) | |
| tree | 1099063af615ba92fb024ce7fa972345dc29c001 /lib/dynamic_debug.c | |
| parent | dyndbg: fix static_branch manipulation (diff) | |
| download | kernel-85d6b66d31c35158364058ee98fb69ab5bb6a6b1.tar.gz kernel-85d6b66d31c35158364058ee98fb69ab5bb6a6b1.zip | |
dyndbg: fix module.dyndbg handling
For CONFIG_DYNAMIC_DEBUG=N, the ddebug_dyndbg_module_param_cb()
stub-fn is too permissive:
bash-5.1# modprobe drm JUNKdyndbg
bash-5.1# modprobe drm dyndbgJUNK
[ 42.933220] dyndbg param is supported only in CONFIG_DYNAMIC_DEBUG builds
[ 42.937484] ACPI: bus type drm_connector registered
This caused no ill effects, because unknown parameters are either
ignored by default with an "unknown parameter" warning, or ignored
because dyndbg allows its no-effect use on non-dyndbg builds.
But since the code has an explicit feedback message, it should be
issued accurately. Fix with strcmp for exact param-name match.
Fixes: b48420c1d301 dynamic_debug: make dynamic-debug work for module initialization
Reported-by: Rasmus Villemoes <[email protected]>
Acked-by: Jason Baron <[email protected]>
Acked-by: Daniel Vetter <[email protected]>
Signed-off-by: Jim Cromie <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/dynamic_debug.c')
0 files changed, 0 insertions, 0 deletions