diff options
| author | Ben Hutchings <[email protected]> | 2014-08-26 07:34:44 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2014-09-24 05:55:15 +0000 |
| commit | 655e5b7c031e84cf8c07cfd6a5944ce53cba1add (patch) | |
| tree | d99c06b802df92b1618fe67fe3a6a5e811b7b43b /lib/dynamic_debug.c | |
| parent | device coredump: add new device coredump class (diff) | |
| download | kernel-655e5b7c031e84cf8c07cfd6a5944ce53cba1add.tar.gz kernel-655e5b7c031e84cf8c07cfd6a5944ce53cba1add.zip | |
drivers/base: Fix length checks in create_syslog_header()/dev_vprintk_emit()
snprintf() returns the number of bytes that could have been written
(excluding the null), not the actual number of bytes written. Given a
long enough subsystem or device name, these functions will advance
beyond the end of the on-stack buffer in dev_vprintk_exit(), resulting
in an information leak or stack corruption. I don't know whether such
a long name is currently possible.
In case snprintf() returns a value >= the buffer size, do not add
structured logging information. Also WARN if this happens, so we can
fix the driver or increase the buffer size.
Signed-off-by: Ben Hutchings <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/dynamic_debug.c')
0 files changed, 0 insertions, 0 deletions